Change the type of the column state to enum, step III (reads) #18392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were missing in 1d76f7b. Luckily, they only affected the test and development environmnents.
Also, remove a spec to test a data migration. It used the column `state`. This data migration has been deployed without issues. We can safely remove the spec.
Instead of passing a symbol, we should have passed a string.
saraycp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #18173 was reverted with PR #18355, I'm going to re-introduce the changes little by little.
This is the second PR, it depends on #18391, it stops reading the state column to start reading the status one.
Includes two fixes that were detected later (#18351 and #18348).
Author: @eduardoj